I know a lot of people are down on Final Cut Pro X, but I've been editing for ten years and I really like FCP X. It's coming a long way from release to get back in the good graces of pro editors. They have done some updates to get functionality that pro editors need, but for 90% of peoples needs, it's perfect. Unless you doing some serious editing that requires a bunch of VFX compositing work and syncing with other pro decks and timecode editing, then it will work perfect fine for you. Also, if you have an iPad, there is a very nice third party software that was just released that turns the iPad into a deck controller. I just bought it a few days ago and it's really helping to streamline some of my editing. You can check it out here - http://store.pixelfilmstudios.com/plugin/app-procutx. Only hitch, you have to have a mac.
If your stuck on a PC (which you should seriously consider going to a mac, especially after Windows 8 release), the only other option I would recommend for people, and there is a bit of a learning curve, is Adobe Premiere. It integrates great with products like After Effects and Photoshop, but some people may be intimidated with the interface when they first start out with it. But Adobe is way way way more pricey. Just something to consider.
End of the day, if you are already on a Mac, go with FCP X. It's way more affordable, it's powerful, and very intuitive to learn. If your on a PC (and unwilling to make a switch), go invest in Adobe Premiere and the rest of the Creative Suite.
If this is just a hobby for you or just need something to edit a few videos quick and dirty, I've heard that Vegas is a good software. But I've never tried it before so don't hold me to it.